Brian Anderson
Brian Anderson
@budziq wow thank you for all these ideas. I think almost all of them are appropriate for the cookbook. I would though like to keep the scope of the cookbook...
Another observation: it's impossible to Ctrl-F the index for a crate name because the badges are images.
Per comments in https://github.com/paritytech/cargo-contract/pull/888 and https://github.com/paritytech/cargo-contract/pull/891, it seems that wasmi requires turning on the signext and mutable globals features explicitly (or perhaps they can be disabled). I haven't looked at...
Looking at the actual invocation of wasm-opt now, I see the code already sets mvp_features_only, so I think this is good as-is. I also see that wasm-opt is not being...
Hi @hwpplayer1. Thanks for the suggestion - we probably should have a license file in place that GitHub understands. The readme for this repo already claims to be licensed CC-BY...
> @brson Was this all resolved by #1431? No, that PR just fixes technical build steps.
Note that some of the existing error handling occurs in `main.zig`, some in `cli.zig`. It seems reasonable to decide on one place.
> For this PR I think we can focus on only improving the error message. However, should we support decimal inputs? Like `1.5GB`? Seems like something people will expect to...
> I know that I have not worked on this code, by no means I intend to stall this, but one thing that I found when looking through the CLI-parsing...
@batiati I have addressed the review items and this is ready for another look.