Brian Anderson

Results 400 comments of Brian Anderson

The CI sanity check is tripping on `println!` invocations in examples that are written correctly. I am willing to change them to `msg!` but it will not be idiomatic.

I'll think about other ways to present those examples.

@CriesofCarrots i just removed the printlns from the examples

Great reviews, thanks.

CI failure is a rustsec advisory unrelated to this patch.

Woohoo. Thanks for working on this @nikomatsakis and @k0pernicus.

@kentfredric woah rust-vmatrix looks very cool. Where is the source code? Where can I read more about it?

I've hit this problem as well in a project where I'm not using the default cargo `src/` directory structure. I'd expect this file to be loaded relative to the directory...

@sticnarf and I discussed that "i know we don't begin the course with abstract engines. maybe we can start with a KvsEngine type, extract the signature into a KvsEngine trait,...