Brian Anderson

Results 400 comments of Brian Anderson

Is this something the maintainers would be open to accepting patches for? I could see it being fairly disruptive to the codebase. It might be done in two steps: adjusting...

Not using exceptions is generally better for rust too, so if there's a different error handling pattern you'd like I'm happy to do that instead.

Pulling the Result and MaybeResult types out of wat-parser.h and reusing them looks like something I can handle. I don't quite understand how to use BuildResult on first read though.

After spending a day working on this I discovered the `Fatal` type, which is used in quite a few places, some of which also are possibly places it might be...

I'll take another pass at the various client crate docs once https://github.com/solana-labs/solana/pull/27188 lands.

Author of the wasm-opt bindings here. I'm glad to see another project interested in using wasm-opt-rs. There are a lot of bugs in the `-preview` release of the crate, and...

@athei I have published wasm-opt crate 0.110.0: https://docs.rs/wasm-opt/latest/wasm_opt/ This version is complete and reasonably well tested for identical behavior to the wasm-opt CLI. It would be reasonable to try to...

Here is the `cargo-contract` PR: https://github.com/paritytech/cargo-contract/pull/766

@kripken I wonder if you could look at the notes at the bottom of the [last comment](https://github.com/paritytech/substrate/pull/12280#issuecomment-1276347029) and comment on the `memories` section and debug sections.

@koute is the goal to keep the `name` section but strip all the debug sections?