Rename KvStore to be consistent with the KvsEngine, SledKvsEngine naming

Open brson opened this issue 6 years ago • 1 comments

Related to https://github.com/pingcap/talent-plan/issues/144.

The KvStore name was created before the KvsEngine trait, but now it's inconsistent with the trait name and the SledKvsEngine impl name. This just makes things less clear than they need to be.

Unfortunately I don't have a great XKvsEngine name for it - MyKvsEngine, CustomKvsEngine, DefaultKvsEngine.

Opinions @sticnarf @mapleFU ?

Jun 04 '19 20:06 brson

@sticnarf and I discussed that "i know we don't begin the course with abstract engines. maybe we can start with a KvsEngine type, extract the signature into a KvsEngine trait, while renaming KvsEngine to MyKvsEngine"

Jun 05 '19 06:06 brson