Brian Anderson comments

Results 400 comments of


                                            Brian Anderson

Rust: spec how string keys are interpreted

I'm putting this on the mvp, but it's probably ok to slip.

Rust: spec how string keys are interpreted

cc @mapleFU

Rust: spec how string keys are interpreted

Here's a string sorting experiment: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=99ec4fd4c0e544282aa7094b718f3ddb They seem to be sorted by code point, then string length.

Add illustration of log-structured storage

Use asciiflow like in project 4.

Rust: discuss request-per-connection vs multiplexing

Some discussion here https://pingcap.slack.com/archives/CF31LFWP7/p1559943113093100

rust/projects: fix sled test `cli_access_server_sled_engine`

Thanks for the patch and sorry for not reviewing earlier @frobiac. I'd rather not add sleeps to fix broken tests. The correct way to fix this is to hook into...

rust/projects: fix sled test `cli_access_server_sled_engine`

@morenol thanks for the suggestion. On closer inspection, I see the tests are already filled with sleeps :( This is not a practice I want to endorse in this course!...

Rust: set up combined test suite and CI for example code

Per https://github.com/pingcap/talent-plan/issues/158, the CI should also be testing rustfmt and clippy.

Rust: add CONTRIBUTING.md

There may be content in https://github.com/pingcap/talent-plan/issues/96 and linked issues to use for inspiration.

Reconsider use of failure crate in rust projects

I am relatively convinced that failure is not the solution to error handling in Rust, but for the mvp we can leave it in and worry about it later.