Results 208 issues of Brian Smith

In build.rs we have some logic for determining whether/which assembly language source files to compile. Separately, we have other logic within the source code to determine whether to use functions...

See https://github.com/rust-lang/rust/issues/119659. This affects all the `#[repr(transparent)]` tuple structs like `N0` where the field is actually used by C or assembly code, but not by Rust code.

After #1908, Windows targets still don't have symbol prefix checking in CI. See branch b/llvm-tools-windows where I left off on this. More work is needed in the script or our...

static-analysis-and-type-safety
test-coverage
good-first-bug

Rust 1.76 is scheduled to be released on Feburary 8th, 2024. Assuming it continues to include the change in https://github.com/rust-lang/rust/pull/118100, we should switch all the `coverage` jobs in ci.yml to...

good-first-bug

- [x] In `mk/{install-build-tools.sh`, should not do `install_packages llvm-$llvm_version`. Instead we should install the tools using `rustup +$toolchain toolchain component add llvm-tools-preview` before the coverage runs. This would require us...

good-first-bug

When reviewing PR #1368, @complexspaces noted: > ``` > const LG_BASE: usize = 2; // Shifts vs. squaring trade-off. > debug_assert_eq!(LG_BASE.count_ones(), 1); // Must be 2**n for n >= 0....

good-first-bug

`cargo package` by default builds the package for the default target, and this is what the current `package` job in CI does. However, this doesn't work well for us as...

good-first-bug

Strawman: * For the next (imminent) release, bump MSRV to 1.61 to enable most `const fn` goodness and newer dependencies. * Provisionally to avoid bumping MSRV past a versoin that...