Brian Robbins

Results 250 comments of Brian Robbins

@zivcaspi thanks for contributing this. This is great, and in fact, I've recently received a request for such functionality, so it is timely as well.

Thanks @ezsilmar. Just triggered a new CI run.

Going through old issues and this one appears to have been missed. Is this related to TraceParserGen?

@ivdiazsa, I am not familiar with all of the runtime side changes to be able to compare this against them, but overall, this change looks reasonable, and would basically make...

For tests, I think you should add a new test trace that gets run through https://github.com/microsoft/perfview/blob/main/src/TraceEvent/TraceEvent.Tests/GeneralParsing.cs. This test basically opens each trace, string-ifies all events, and then diffs them against...

@shirhatti, is there guidance on the right way to address this?

@aaronhudon just trying to understand the details here - are all the necessary files present if you don't publish as SingleFile? Would you be able to put together a minimal...

@beteitle, thanks for your contribution. In general, I want to keep these kinds of safeguards by default. Not having them can result in invalid/incorrect data in some cases. If you're...

I suspect that this is due to missing dependencies. Unfortunately, [Windows 7 is no longer supported](https://support.microsoft.com/en-us/windows/windows-7-support-ended-on-january-14-2020-b75d4580-2cc7-895a-2c9c-1466d9a53962). If a particular version of TraceEvent works, but the next does not, it's likely...