perfview icon indicating copy to clipboard operation
perfview copied to clipboard

Ignore errors instantiating symbol checksum algorithm.

Open beteitle opened this issue 5 years ago • 2 comments

Ignore errors instantiating source checksum method during symbol source lookup. For many use cases, source checksum is a "nice to have", but not a requirement. Cryptography method instantiation may fail in certain cases. For example, if FipsAlgorithmPolicy is in place on your host machine, you are not allowed to instantiate MD5. Failing to checksum should not prevent source lookup workflow in my opinion (seems to work fine without it being performed for well behaving source server).

beteitle avatar Aug 05 '20 02:08 beteitle

CLA assistant check
All CLA requirements met.

ghost avatar Aug 05 '20 02:08 ghost

@beteitle, thanks for your contribution. In general, I want to keep these kinds of safeguards by default. Not having them can result in invalid/incorrect data in some cases. If you're running into cases where where the algorithms can't be executed, one option would be to have a flag, similiar to /UnsafePDBMatch where you can opt-out of these safety checks. I would be supportive of this.

brianrob avatar Oct 20 '20 21:10 brianrob