Brian Robbins

Results 250 comments of Brian Robbins

@lupino3 thanks for submitting. I will need a bit of time to look through this, but consider this an ack.

It looks like the reason for this error is that you're specifying .NETTasks:0:0, which disables the provider. However, this provider is not enabled by default (it used to be), and...

It is possible to have a better error message - this is just one that happens to come from the `HRESULT` that comes back from the ETW call. I'll leave...

@davkean, I'm not sure why this custom logic is here, at least for symbol servers, where HttpWebRequest timeouts should kick in. There is also a path for copying via `CopyStreamToFile`,...

Seems reasonable to depend on HttpWebRequest, at least for the case that uses it. If you want to make a PR for this, I’d be happy to accept it. If...

Yes, this repo is the authoritative source for TraceEvent as well.

@davkean is this still an issue or should we close this?

I do think that both execution time and memory are concerns here. At this point, it's not clear to me whether or not we do want to take this change....

@mjsabby, are there corresponding runtime changes for this?

I'm not aware of an issue here. Can you share a simple repro and a trace that exhibits this issue?