Brian Robbins
Brian Robbins
@jakobbotsch, have you seen this before? I'll admit, I've really not used the LBR support.
I am not surprised at this. Looking at the code - at a minimum, this is coming from the `PayloadFetch` struct, which converts incoming signed and unsigned types into their...
@tomuxmon would you mind testing #2315 and see if that fixes your issue?
@tomuxmon would you mind testing https://github.com/microsoft/perfview/pull/2315 and see if that fixes your issue?
@copilot, the TraceEvent.Tests are failing because some of the values are formatted differently now that they are unsigned types. Please try running the tests and following the instructions when they...
I've had a chance to look through this PR. I'd like to have a conversation about what the goal is here and have some follow-up questions on several of the...
> The main goal is to support Native AOT for a number of diagnostic tools that use this library. Most choices are downstream of that goal: I think that we...
@noahfalk and I chatted about this offline yesterday. When I look at this change, I am most worried about it from the perspective of support cost. That's both in terms...
@agocke, thanks. I will re-review this. One thing that I noticed is that this change has a very large number of whitespace-only changes. Can I ask you to revert these...
Thanks for poking this @jdu2600. Let's see if copilot can fix this.