Brian Robbins

Results 250 comments of Brian Robbins

This seems reasonable to me. Having some tests in https://github.com/microsoft/perfview/tree/main/src/TraceEvent/TraceEvent.Tests would be a good thing. Probably just create a new `TimeStamps` directory. @pharring, do you have concerns with this? From...

Thanks @pharring. Much appreciated. Yes, I think these are reasonable things to do. @vitalych, would you mind adding some tests?

I think that you want `GC Heap Alloc Ignore Free Stacks`. This was a rename from a long time ago. Would you be up for creating a quick PR to...

Yes, you're right - this is just a matter of porting the view. Should be pretty straight forward. I can do this, or if you're interested in submitting a PR,...

@elinor-fung thanks for submitting this. While these events can be costly, they are often quite helpful, as ETW traces are often used for troubleshooting issues that are related to assembly...

@ryandle, thanks for the analysis. I agree that the second fix sounds right to me. Would be happy to accept a PR on this. 64 is the default value, though...

From `git bisect`, this looks to be caused by #1717.

If I recall correctly, the behavior you're seeing is expected because the kernel module cannot be built and installed inside the container. If you need kernel-level data, then you will...

@tommcdon, no we should not need to do that - it is supported inside containers. You just don't get some of the context information because the kernel module isn't loaded:...