Diagsession files not opening normally

[evschaff]

Perfview recently started having an issue with open .diagsession files collected in VS. If you double click on the file in the PerfView GUI then the application extracts the contents of the diagsession, but the children items (should show an etl file) don't appear.

This is what it looks like after double clicking the diagsession:

There's a workaround for this. If you open the file by entering the full path in the search bar and hitting enter, then you are able to open the file and expand it as normal by double clicking.

This is what it looks like after the workaround:

The diagsession opening code hasn't been changed in years so there is likely another issue that was recently introduced to cause this.

Here's a diagsession that can be tested with Report20230224-2305.zip

[brianrob]

From git bisect, this looks to be caused by #1717.

[rzikm]

That's weird, it happens only with the diagsession files. The file seems to be opened fine and the Children property is populated correctly, but the treeview just is not updated (eventhough the PropertyChanged event is fired).

Another workaround I discovered is hitting F5 in the treeview mode to force refresh.

I am at loss, I don't see anything wrong with the code which populates the child items and I don't have any Ideas how to debug this further.