Brian Robbins

Results 250 comments of Brian Robbins

@copilot, in addition to the current change, I'm also noticing that under high contrast, top menu bar, file path drop down, and Filter are all bright gray under high contrast...

@copilot, this change is not working. Please undo the change and then let's re-assess. It looks like the issue is not in PerfView's implementation of dark mode, but instead in...

Copilot Post-Mortem: - Copilot was unable to produce a viable fix for several iterations. It appears the problem is that it was focusing on the PerfView dark mode theme, while...

Copilot Post-Mortem: - Great example of an issue that requires minimal coaching. - The stack trace was sufficient for copilot to know what to do. All I had to do...

> I asked for a change (already done by Copilot). PTAL @marklio. Good call @cincuranet.

Additional Copilot Post-Mortem: It looks like once a maintainer makes a comment that causes copilot to respond with a code change, that maintainer's approval no longer counts. That looks like...

It seems like the current behavior for approvals is this: - The originator of the PR (the person that assigns the issue to copilot) can never approve. - If another...

@careless6666, apologies for the very late response. I am trying to go through the backlog. What sort of change are you looking for here?

This is interesting - I had not seen it before. This appears to be in the stack viewer itself, and not in the `StackSource` code. I did a test where...

Confirmed that this behavior is pervasive across TraceEvent. The type is selected here: https://github.com/microsoft/perfview/blob/1c22582c132ef7ea4733cb24ef75b04d319b52ce/src/TraceEvent/DynamicTraceEventParser.cs#L1374. Given how pervasive this is, I am inclined to keep it as is, and ask that...