Brian Lopez

Results 60 comments of Brian Lopez

> If performance is at all an issue, we could indicate common encodings (I expect to see a lot of UTF-8) with something cheaper than a second String. In [mochilo](https://github.com/brianmario/mochilo/blob/master/genperf.rb)...

Nice work! > Note that US-ASCII gets lifted to UTF8, but I think that doesn't matter :+1: to that

@carlosmn went ahead and added a failing test for that. Will get things fixed up so we only ever hand the caller `max` bytes. I don't think that'll break anything...

I had this problem on OSX too. I was using RVM and had run the cleanup command which wiped out the source/debug symbols. Reinstalling that ruby fixed it.

Er, what I meant by that was - +1 to this change. The memory corruption thing is a separate issue. I really need to figure out what to do with...

I think we'd probably need some FFI bindings or something to make this work with jRuby. I won't have time to tackle that for a while, would you be interested...

@headius I'd feel a lot better if we found some way to link to libicu for jRuby, only so the detection and transcoding results are consistent across all of the...

This is definitely interesting... Have you tired this on different ICU versions to see if it's any different?

I just pushed up 0.7.5 - would you mind giving that a try?