bzip2-ruby icon indicating copy to clipboard operation
bzip2-ruby copied to clipboard

Set dependencies with ~> to prevent major verion breakage

Open sodabrew opened this issue 10 years ago • 6 comments

Recent PRs #25 and #26 failed because rspec 3.0 matches ">= 2.0.0". This PR pins rspec, rake, rake-compiler as needed.

sodabrew avatar Jun 03 '14 11:06 sodabrew

Now the builds are broken due to a memory issue. Also updated .travis.yml to build Ruby 2.0 and 2.1.

sodabrew avatar Jun 03 '14 12:06 sodabrew

The situation is quite confusing but basically I removed a previous memory leak fix. Maybe there really is a memory leak but the fix caused segfaults for me in certain cases. I only use this library in rake tasks so short-term memory leaks aren't a big issue for me.

chewi avatar Jun 03 '14 12:06 chewi

:+1:

brianmario avatar Jun 03 '14 17:06 brianmario

Er, what I meant by that was - +1 to this change. The memory corruption thing is a separate issue. I really need to figure out what to do with this gem :\

In short, it probably needs to be rewritten or abandoned (I mean, it is now)

brianmario avatar Jun 03 '14 17:06 brianmario

I remembered that ALLOC_N should be paired with xfree and not ordinary free, and setbzf->buf = NULL` after each free. Now it just doesn't work instead of crashing. Progress!

sodabrew avatar Jun 04 '14 05:06 sodabrew

Thanks for taking the time to look into this, it is appreciated.

chewi avatar Jun 04 '14 08:06 chewi