update declarative config to 1.0-rc.2
- adds service detector
- configurator name and config are not required
see https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.1 and https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.2
Codecov Report
:x: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.35%. Comparing base (d5f5aa7) to head (5c3b58f).
:warning: Report is 42 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| .../Config/SDK/ComponentProvider/OpenTelemetrySdk.php | 0.00% | 5 Missing :warning: |
| .../Config/SDK/ComponentProvider/Detector/Service.php | 0.00% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1733 +/- ##
============================================
+ Coverage 68.26% 68.35% +0.08%
- Complexity 2970 2972 +2
============================================
Files 448 449 +1
Lines 9029 8718 -311
============================================
- Hits 6164 5959 -205
+ Misses 2865 2759 -106
| Flag | Coverage Δ | |
|---|---|---|
| 8.1 | 68.05% <10.00%> (?) |
|
| 8.2 | 68.32% <10.00%> (?) |
|
| 8.3 | 68.31% <10.00%> (?) |
|
| 8.4 | 68.26% <10.00%> (?) |
|
| 8.5 | 68.25% <10.00%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...Strategy/SemanticConventionSuppressionStrategy.php | 100.00% <100.00%> (ø) |
|
| src/SDK/Trace/TracerProvider.php | 100.00% <ø> (ø) |
|
| .../Config/SDK/ComponentProvider/Detector/Service.php | 0.00% <0.00%> (ø) |
|
| .../Config/SDK/ComponentProvider/OpenTelemetrySdk.php | 0.00% <0.00%> (ø) |
... and 216 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d5f5aa7...5c3b58f. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@open-telemetry/php-approvers I've addressed review comments, ready for re-review please