Brett McBride

Results 292 comments of Brett McBride

Local root span: yes that's right. It's something like global access to the root-most span in the current context. We'd use it for things like updating the name of the...

As a SIG maintainer, I'm also interested in the "retry implementation is not specified" section here. Various SDKs have implemented an exponential backoff retry, but in different ways. We have...

> can you review as it looks like PHP is one of the users of this env variable @codeboten sorry I'm late with the review, but the proposed usage would...

I really like the idea of a retry policy being an interface, so that it can be expanded in future with either official or contrib/3rd party policies. Perhaps spec begins...

I'm happy to accept this as-is and complete it incrementally, if you don't have much time. If you're happy with that, can you add `@experimental` tags everywhere, and fix the...

> Does this PR expose any way to configure which suppression strategy is used by the SDK when used via autoinstrumentation bundles? Was expecting to see some environment variable configuration,...

I'm not sure that we want that as default behaviour, wouldn't this mean runtime opentelemetry exceptions would/could break the observed application? https://opentelemetry.io/docs/specs/otel/error-handling/#basic-error-handling-principles

> What would you think about adding a "trigger_error" option Adding a new option seems safe enough, if we think there's a use-case for it. Would you like to work...

Just so that you're clear, the tracing in frankenphp is not the same thing as opentelemetry-php. It looks like it will create a span for the incoming web request, but...

I don't have any specific experience with frankenphp, however if it's running PHP and using composer, it should work. The first things to check are that you've followed all of...