Brentley Jones

Results 299 comments of Brentley Jones

@sgowroji Can you ping someone to get this reviewed?

I think the paths aren't based on convenience symlinks, but instead relative to `execution_root`. If you add `$(bazel info execution_root)/` as a prefix they should resolve.

Do you want to mention in the PR description that this fixes https://github.com/bazelbuild/bazel/issues/16151? (I'm still testing that though.)

This works in my testing. I've asked a couple others to verify as well though.

It's a git clone. I've changed the command to use https for easier use for people that don't have ssh keys setup on GitHub.

Yes. This is preventing people from using `--incompatible_remote_build_event_upload_respect_no_cache`. Those test binaries can be large, and there can be hundreds of them, and they don't want them uploaded. They instead turn...

I think for all of these, they shouldn't upload if it's only BES that is trying to upload them. If they would upload normally, then they will be uploaded normally....

Sorta. That already exists as `--experimental_build_event_upload_strategy=local` right? My request is a little different. Paths can/should be converted for all blobs that are uploaded, but I don't want something uploaded simply...