Brentley Jones comments

Results 299 comments of


Brentley Jones

ios_sticker_pack_extension stub binary architectures aren't stripped, causing DynamicFrameworkSlicer not to remove extra architectures

We'll look into a fix and open a PR

ios_sticker_pack_extension stub binary architectures aren't stripped, causing DynamicFrameworkSlicer not to remove extra architectures

Looking into this more, we won't strip the stub, but we will enhance the framework importer to ignore the stubs (since they won't use the frameworks anyway).

macos_bundle with ios base_sdk

Yes. Here is an incomplete (no tests) and bit-rotted commit that adds it: https://github.com/bazelbuild/rules_apple/commit/558ea6a7fa5f2cb15b6bb4278ab12c46b6d11444 I would review and help shepherd something in, if a PR was opened.

macos_bundle with ios base_sdk

There has been some refactoring. I'll take a stab at getting it back to the same (no-test) state today.

macos_bundle with ios base_sdk

#1085

Allow timeout on server and directory ownership

@mostynb Can you share the full launchd setup process here? We are in the process of finalizing our local proxy and while we have a solution something launchd related would...

error: the following arguments are required: --framework_binary

Can you post your `BUILD` files?

apple_dynamic_framework_import regressions

@Keith This should stay open. I'll update it to say the first part is fixed.

apple_dynamic_framework_import regressions

@thii We stopped stripping symbols as part of our IPA Post Processor. We now strip the symbols before they are imported by Bazel.

apple_dynamic_framework_import regressions

Neat. We also did Swift symbols stripping as part of the `ipa_post_processor`, so that would need to be done (as well, in a different change).