Brentley Jones

Results 299 comments of Brentley Jones

@asifmohd It's now about 10% slower than master for us. And when we make it so we instead have 275 independent targets we get into a deadlock and it never...

Should be able to use `implicit: true` to have it look in the built products directory.

Does this need a new label to get imported?

https://github.com/bazelbuild/bazel/pull/15417 is an example of changing a flag to accept tildes. I think we can do that for this flag, and others, as well.

It was on CI. All I can think of is the directories failed to be created, because of low disk space.

Does this fix any known bug? Is it worth cherry-picking into 5.3?

Is this fixed by https://github.com/bazelbuild/bazel/commit/f440f8ec3f63e5d663e1f9d9614f05a39422102a?

You mention `--stamp`, but `--embed_label` should also be supported, right?

We also need this. The original iOSSnapshotTestCase added this exact functionality for the same reasons that @maxx-cyber laid out above: https://github.com/uber/ios-snapshot-test-case/blob/0bbf957c9556e143d94d2e209bcea35a63efad3f/FBSnapshotTestCase/Categories/UIImage%2BCompare.m#L117 On Catalina, with the simulator generating everything with Metal,...