Brendon Muir

Results 265 comments of Brendon Muir

Just digging a bit deeper, it seems that it's possible to escape the file names: https://github.com/markevans/dragonfly/blob/e5ca848aef74c5106d328ff06ee51dcafb8825d2/lib/dragonfly/content.rb#L170 Is there a reason why they're not escaped in this instance?

Sorry, of course that evaluates to `true` but then there isn't actually any escaping, just quoting: https://github.com/markevans/dragonfly/blob/e5ca848aef74c5106d328ff06ee51dcafb8825d2/lib/dragonfly/content.rb#L172-L173 https://github.com/markevans/dragonfly/blob/3ad0c6dded8f69773e042714be1f877b3c05797a/lib/dragonfly/shell.rb#L23-L26 Could we perhaps use `Shellwords.escape()`?

@markevans, would you be able to provide a bit of insight on this one? I'm happy to put together a PR to fix it but just need some direction on...

I was a bit reluctant at first, but the switch to Faye really was quite easy. The Railscast of Faye is still quite current, and the hardest part was writing...

Hi @emrox, I'm happy to look at this for you. Can you give me a bit more of a detailed rundown of the problem? I've looked at your code and...

Hi @markevans, would you mind looking at this PR? Let me know if you think it needs further improvement.

Hi @markevans, I'm upgrading the app where I use a fork of dragonfly with this PR applied. I notice you're still actively maintaining the gem so I wondered if you'd...

That's interesting. I guess it's a downside of the underlying database state changing at save but not being updated in the object itself. I'm not sure what the answer is...

Perhaps there's a cleaner way to do this?

Sorry, by cleaner, I mean safer.