Brendon Muir comments

Results 437 comments of


                                            Brendon Muir

Inview and initialisation after context has been scrolled to the bottom

I think I've found the reason, that there is an assumption that the waypoints are initialised when the context hasn't been scrolled yet (and is at the top of the...

Inview and initialisation after context has been scrolled to the bottom

In terms of code, changing this: ``` javascript else if (freshWaypoint && axis.oldScroll >= waypoint.triggerPoint) { waypoint.queueTrigger(axis.forward) triggeredGroups[waypoint.group.id] = waypoint.group } ``` to this: ``` javascript else if (freshWaypoint &&...

Inview and initialisation after context has been scrolled to the bottom

I figured that instead of hacking around the problem, it would make sense to only trigger fresh waypoints when they're actually in view. Then we're not making any assumptions about...

Inview and initialisation after context has been scrolled to the bottom

Hi @Jontis00, unfortunately no one ever replied to my work. Fingers crossed for yours. :)

Inview and initialisation after context has been scrolled to the bottom

By the way, did my PR also solve your problem? I've not looked in detail but can see they deal with things a little differently.

Inview and initialisation after context has been scrolled to the bottom

Thanks @Jontis00, yes I see that depending on the use case, default triggering might be a desirable thing, as you demonstrate. Perhaps this functionality should be an option that can...