Brendon Muir

Results 265 comments of Brendon Muir

Hi @mttdffy, given it's just one file, I ended up just using the asset pipeline to include it in my project like one would any other local CSS file. Probably...

The root `index.scss` is a bit weird. I'm not sure how this could ever be referred to. I'm not sure how active this project is anymore. I'd be a bit...

Can you give a bit more information? What part of `normalize-rails` is causing that call? What would you like to change specifically?

Could be, though that's strange. Can you test with the standard `normalize.css` file? We'll still need something like a line number etc.. before we can figure this one out any...

I think I've found the reason, that there is an assumption that the waypoints are initialised when the context hasn't been scrolled yet (and is at the top of the...

In terms of code, changing this: ``` javascript else if (freshWaypoint && axis.oldScroll >= waypoint.triggerPoint) { waypoint.queueTrigger(axis.forward) triggeredGroups[waypoint.group.id] = waypoint.group } ``` to this: ``` javascript else if (freshWaypoint &&...

I figured that instead of hacking around the problem, it would make sense to only trigger fresh waypoints when they're actually in view. Then we're not making any assumptions about...

Hi @Jontis00, unfortunately no one ever replied to my work. Fingers crossed for yours. :)

By the way, did my PR also solve your problem? I've not looked in detail but can see they deal with things a little differently.

Thanks @Jontis00, yes I see that depending on the use case, default triggering might be a desirable thing, as you demonstrate. Perhaps this functionality should be an option that can...