ranked-model icon indicating copy to clipboard operation
ranked-model copied to clipboard

Published 20 hours ago • verified publisher icon brendon

Fix/place new elements in front

Open emrox opened this issue 7 years ago • 2 comments

fixes #99 when placing new elements in front (or with the same rank as an already existing)

emrox avatar Jul 22 '16 16:07 emrox

Is there any issue with this PR or any reason not to apply it?

emrox avatar Sep 18 '18 09:09 emrox

Hi @emrox, I'm happy to look at this for you. Can you give me a bit more of a detailed rundown of the problem? I've looked at your code and the issue but it's not clear to me if this is a bug.

Are you saying that when you grab an existing items position and set your moving item's position to the existing items position (i.e. push the existing item down the list and insert this moving item there) that it doesn't work as expected?

It's my understanding that you shouldn't use the rank column directly but rather the position pseudo-value. So grab the existing items swimming_rank_position then use that to move the other item.

Let me know your thoughts on that.

brendon avatar Sep 18 '18 22:09 brendon