Brendon Muir

Results 265 comments of Brendon Muir

Thanks @EastDesire. I don't think that would work for me because I am including `jscolor` within a Webpack build so there is no script tag. You could go something along...

Sorry, looking into it further, you'd have to follow through with @kristianmandrup's recommendations of exporting a default `JSColor` object before this would work well. Currently you're relying on `window` which...

Thanks @EastDesire, I totally understand what you mean. I was skeptical about Webpack and it took a long time for me to understand why it helps. The above code looks...

You're a legend @EastDesire :) That worked perfectly :)

The only small thing I noticed (which is probably not small in its solution!) is that there isn't a way to remove jscolor from an input. It's probably not a...

Thanks @EastDesire, I might have a go a that during the week and send you a PR if I have time :)

Just had a quick look through the code and my current thinking is: - [ ] Keep a copy of the original element and hide/detach it when installing `jscolor` on...

Haha! Yes that sounds like a mammoth job! For now it's not a problem for me as my app is just a traditional multi-page Rails app. I'll dabble with `turbolinks`...

100% @daveharris, I wouldn't recommend using this gem anymore. It's almost guaranteed to never get updated due to dependency hell.

Hi @eveevans, it's basically a roadblock. The gems that this library depends on only implement less 1.7.0 and there isn't really an easy path to upgrade beyond this as much...