Semantic-UI-Rails-LESS icon indicating copy to clipboard operation
Semantic-UI-Rails-LESS copied to clipboard

Update to Semantic 2.4 ?

Open eveevans opened this issue 5 years ago • 4 comments

The latest version of Semantic UI is 2.4.2 And the latest version of the Gem is 2.3.1... Why we haven't latest version ?

eveevans avatar Jan 30 '19 22:01 eveevans

Hi @eveevans, it's basically a roadblock. The gems that this library depends on only implement less 1.7.0 and there isn't really an easy path to upgrade beyond this as much of the support dependencies are abandoned. Semantic UI recently pulled in a requirement for Less > 3 which means we're stuck. If you have time and want to investigate and work on the dependencies issue I'd be more than thankful.

For me, I ended up switching to webpacker and pulling Semantic UI in that way (this wasn't easy either).

brendon avatar Jan 31 '19 01:01 brendon

Thanks @brendon I really appreciate your response.

I was afraid of that. Where can I find a discussion about that ? Which are the problematic dependencies ?

And thanks for the tip.

eveevans avatar Jan 31 '19 23:01 eveevans

Hi @eveevans, here's the Semantic UI upgrade PR:

https://github.com/Semantic-Org/Semantic-UI/pull/6512

This repo depends on https://github.com/metaskills/less-rails, which depends on https://github.com/cowboyd/less.rb which depends on https://github.com/cowboyd/commonjs.rb

Here's my issue at less.rb: https://github.com/cowboyd/less.rb/issues/87

Someone attempted to go to Less 2: https://github.com/cowboyd/less.rb/pull/79

Hope that helps :)

brendon avatar Feb 01 '19 00:02 brendon

My gut feeling about this would be to abandon all this ruby based less stuff and just parse the whole thing with less.js instead.

brendon avatar Feb 01 '19 00:02 brendon