Brendon Muir

Results 382 comments of Brendon Muir

Hi @fabn, I'd be interested to see if the work on @scope_changed fixed this bug. Could you let me know?

Hi @fabn, given that the Rails 5 compatible attribute swapper is now in master, let's try to close this one off with a solution around that existing code. I think...

Hi @fabn, just reviewing my code, I've been able to remove my scope overrides and am now about to just do this: `acts_as_list :scope => [:ancestry]` This is my `move`...

Hi @patrickdavey, I'm happy for you to have a go at getting the patch working with master. `acts_as_list` is a fairly simple codebase. The tests are super easy to run....

All good @patrickdavey. I remember looking at `closure_tree` for a new project but got freaked out from memory. I can't remember why. I ended up with `ancestry` and `ranked_model` though...

Lol! Come back home man!

Hi @cipater, can you come up with a failing test for `acts_as_list`? We can then look at fixing this. I use ancestry with acts_as_list as I mentioned further up the...

@fabn, not sure what to do with this one. Should we close it for now?

Hi @fnordfish, that's an interesting one. Do you have time to dig into the code and find out why this is happening? Start a PR with one or two failing...

Thanks @fnordfish, ah yes we've had that raised in the past. It also is a concern when there is two items with the same position in a scope. There's nothing...