Brendon Muir

Results 436 comments of Brendon Muir

Ok, so I figured out the issue with not being able to set more than one attribute on a `groupTag` and it's to do with how `createContainerElement()` worked. It would...

The test suite as it stands now runs green. I'm keen to add some tests to test the new functionality but would like some feedback on the overall PR before...

Any chance I could get some feedback? Even if it's just a "yes, good, write some tests" or "think about it this other way".

@seanpdoyle, I'd love to get some feedback on this PR. I'm not sure where it fits within your greater ambitions but it would be helpful to modify more than one...

Still keen to get some feedback on this.

@brunoprietog, I'd love a review of this PR.

Just on holiday at the moment but will look at this next week hopefully :)

This is an interesting approach. Is the idea that you'll allow a time period where using this overridden method issues a warning, and then at some time in the near...

Yes I think it makes sense to remove the custom `redirect_back_or_to` and rely on the Rails version. I imagine the breaking change would be that users would need to update...

Ok, that sounds good. Should we look at raising a rails deprecation warning instead of a straight Ruby warning using `ActiveSupport::Deprecation`? That way people who run with `config.active_support.deprecation = :raise`...