Brendon Muir

Results 382 comments of Brendon Muir

> > I think we also need more tests for this one just to be sure it's working in all cases. > > Were there particular cases / classes of...

Hi @DanielHeath, sorry about the delay, those tests look good. Certainly good to exercise the code a bit more :) I'm bringing in @swanandp on this for a look too...

Interesting approach @DanielHeath :) @swanandp, would you be able to take a look at this? :)

I think if @swanandp could take another look that'd be cool :)

Sorry @DanielHeath, I'm struggling with the size and complexity of the change and I'm worried that it will have unintended side-effects for others of I don't go through it thoroughly...

Thanks @DanielHeath, I totally understand. Just when you get the time. It might be easier for me to assemble a change based on this one that just focuses on the...

Hi @DanielHeath, I spent a few hours trying to work through this code last night and I'm afraid to say I'm still finding it very difficult to understand. I think...

Hi @Tao-Galasse, `acts_as_list` does all its work in an `after_` callback so that would explain what you're seeing I guess. I can't think if anything else to help unfortunately. Let...

I honestly have no idea :D If it was me, I'd be using breakpointing (or just `raise @plant.inspect` to check the status of the various objects involved at various points...

That's very strange. Definitely sounds like a bad interaction between `rails` and `acts_as_list`. Would you mind starting a PR with a failing test for this scenario so we can see...