Brendon Muir

Results 436 comments of Brendon Muir

> Since Sorcery now supports Rails 7.1 and above, we can use Rails.application.deprecators. I think that’s a great idea. Excellent. @atolix, would you be ok with switching to that?

> @brendon > > Thanks for catching that. I've updated the code to define a dedicated Sorcery.deprecator instance instead of relying on ActiveSupport.deprecator, following the Rails documentation you linked. >...

I found this article: https://blog.saeloun.com/2024/11/19/rails-7-1-adds-application-deprecators-method/ They seem to store their deprecators globally so maybe it's ok :)

> > Thanks for that :) Just one more worry from me. Will it be a problem having the deprecator stored as a class variable? Could this potentially cause problems...

Hi @utkarsh2102, would you be keen to put a PR together with those changes? :)

@utkarsh2102, just following this up :)