Roman Valls Guimera

Results 259 comments of Roman Valls Guimera
trafficstars

Quite hardcore/hardcoded changes not to be merged to main, but I see your intent. Changes look fine within those premises, so I'd say go ahead and deploy to UoM demo...

Thanks for this Andrew! Closing this for now as we'll not be merging and keeping the branch around so that we can revisit this and implement/merge once GA4GH impls (and...

After bumping into https://github.com/flamegraph-rs/flamegraph/issues/39#issuecomment-561125082, I realised that we don't need this to be integrated with Criterion anymore: ![Screenshot 2023-01-16 at 2 32 42 pm](https://user-images.githubusercontent.com/175587/212592908-5b0360ef-37b5-4705-aa8d-d81071f31959.png) ![Screenshot 2023-01-16 at 4 47 24...

This needs to be followed up with [`not-perf`](https://github.com/koute/not-perf) since `perf` generates way too much data (~4GB) for this to be practical/runnable under free tier CI, see for details: https://github.com/flamegraph-rs/flamegraph/issues/248#issuecomment-1386480336

Followup on profiling fixes/discussion happening on https://github.com/koute/not-perf/issues/32 and https://github.com/cmyr/cargo-instruments/issues/84#issuecomment-1550683996

Good read and tips: https://ochagavia.nl/blog/continuous-benchmarking-for-rustls/ Good perf tool: https://github.com/Granulate/gprofiler-performace-studio Good GH integration: http://codspeed.io https://github.com/orhun/git-cliff/pull/768/files

Revisit this with https://github.com/EGA-archive/crypt4gh-rust

https://umccr.org/blog/htsget-rs-crypt4gh/

https://logankeenan.com/posts/rust-axum-and-cloudflare-workers/

Local-run `cargo criterion` (full benchmark) seems broken (on OSX): ``` (...) Running `target/debug/htsget-actix` 1.5.0: Pulling from ga4gh/htsget-refserver Digest: sha256:b93ab0593f58165351a136f19661228aec203ccaa74d746bd309e8936d8038de Status: Image is up to date for ga4gh/htsget-refserver:1.5.0 docker.io/ga4gh/htsget-refserver:1.5.0 WARNING: The...