htsget-rs
htsget-rs copied to clipboard
umccr
feat: GA4GH passport demonstration
Not for merging.
Just a quick demonstration that we can deploy of passports as Auth headers.
asking for review not for merging purposes.. just let me know anything I've done wildly wrong.
If ok - can we have this branch deployed to UoM demo?
Quite hardcore/hardcoded changes not to be merged to main, but I see your intent. Changes look fine within those premises, so I'd say go ahead and deploy to UoM demo 🚀
Yes to get rid of the embedded keys we'd need to instigate a new config mechanism - and probably move the either auth into some sort of plugin architecture. Which is a bit more than I want for this demo.
I don't know how to deploy to demo btw. (I mean, is it literally the CDK in deploy?)
Thanks for this Andrew! Closing this for now as we'll not be merging and keeping the branch around so that we can revisit this and implement/merge once GA4GH impls (and elsewhere upstream) are a bit more stable? Probably worth looking at it again once you're back from Sweden?
Yes no problems - I am going to grab the code and possibly put it in a standalone GA4GH repo of "passport decoders" (in different languages). So it won't need to have any htsget tie in.. But yes - should re-visit later specifically for htsget