Brad House

Results 249 comments of Brad House

Do you happen to have another backtrace I can evaluate? Just to see if they're the same? So all crashes are on Windows 7 though? Hrm, I don't think I...

Actually, just realized we always set _WIN32_WINNT to 0602 which is Windows 8 when compiling c-ares. Wonder if this could be related somehow, as the size of some structures could...

I did add a test case for calling ares_canel() with a lot of pending requests. I haven't seen it fail, however. #803 has that test case. There are a few...

well, i'm hoping a later c-ares version will magically fix it. it is suspicious that your only reports are on windows 7 though. since 1.29 we did start running windows...

I've been racking my brain over how there may be a use after free in this case. The only thing I can come up with is if ares_evsys_win32_afd_cancel() returns false,...

So i decided to try to switch up the entire methodology used, have a PR I'm working on in #811. I still need to do some fine tuning and cleanups....

seems reasonable, guess I need to fix the freebsd image for building that and on windows set google test to a specific tag since its now requiring c++17

If you update your branch the CI builds should work.

Looks like this supersedes #2080 as it includes changes from that, and then also fixes https://github.com/sonic-net/sonic-buildimage/issues/10050 I'd think this *really* needs to get merged for the next release. VXLAN just...

@VladimirKuk what do we need to do to get this merged? I see you had asked if `updateDbPortOperStatus(port, status)` could be moved outside the `if`, implying just always call it....