Brad House

Results 249 comments of Brad House

Looks like this is based on https://github.com/slsa-framework/slsa-github-generator/tree/main/internal/builders/generic but you're using the generic template, right? As far as I can tell, you're supposed to actually modify this template to build the...

@JoftheV please respond or I'll need to close this PR

> Approve and commit You need to reply to my comments above, this PR doesn't look complete.

if I'm not mistaken, this is more like what you're after: https://github.com/bradh352/c-ares/blob/slsa/.github/workflows/package.yml

closing, #906 should address what you're really looking for.

Sure, make sense to have a flag to skip environment loading. Could be considered a "risk" anyhow. We have configurable options for anything that might have been read from the...

no problems on this end, I'm happy to accept a PR to add an option to disable reading from the environment as long as it covers all cases. I've never...

I'm almost done with this already. I just have to hook in a couple more things then enhance the test system for testing it properly. I really should just finish...

@createyourpersonalaccount I guess I should clarify a bit more on this. My branch is here: https://github.com/bradh352/c-ares/tree/DoT The part I'm almost done with is what I'd consider Phase 1, which only...

@createyourpersonalaccount you'll just need to look at the diff from main from my branch, the commit history on it is pretty bad because I derived multiple other PRs from that...