Brad House

Looks like even glibc uses the same implementation (or at least based on the same one with the same issue): https://sourceware.org/git/?p=glibc.git;a=blob;f=resolv/inet_net_pton.c;h=aab9b7b58228bb2db15cb41182666ec95122d581;hb=HEAD#l64 I think this may be a good find as...

Heh, not that I'm aware of :) Just the function imported that does dotted decimal conversion happens to "support" it ...

Is this actually causing an issue on MacOS? Lots of platforms have these warnings with c-ares because c-ares compiles every file on every platform regardless of if it is used....

I agree, however @bagder set a requirement that all build systems must use the same file for list of sources for all the various build systems we support (nmake makefiles,...

can you elaborate on what you are asking? There are already configurable timeouts

ares_init_options() ARES_OPT_TIMEOUT/ARES_OPT_TIMEOUTMS combined with ARES_OPT_TRIES determines the overall time any query can take. If that's not enough, you can always handle the timeouts yourself by adjusting the timeout parameters passed...

Looks like its going in the right direction. I would think though that we should make ares_parse_srv_reply() call ares_parse_srv_reply_ext() so we don't have 2 basically identical code paths. Basically make...

anytime you're dealing with message parsing itself, its always better not to do it too often ... most bugs tend to be in that sort of code. So making the...

Sorry for the delay, been slammed lately. I think the setters should be private, and only the getters be public. The setters would be tested already in the internal implementation,...

sorry, life's been crazy. I'll really try to get to this review this week.