Brad House
Brad House
a few comments here. 1. You can't modify the hints structure since a newer c-ares version would try to read out of bounds if the app was originally linked against...
I think the missing thing is adding a new ai_flag to indicate if the dnsrec_a and dnsrec_aaaa should be attached to the answer or not. Don't know if it makes...
I will review this weekend. I did see a comment related to configuration, its ok to add members to the end of the ares_options as long as they aren't members...
Hi David, sorry for the delay. Day job has me crazy lately. I'll try to carve out some time.
sorry for the long delay here, i just did a review of this. I think it could be greatly simplified by not adding an `is_failed` flag since it can be...
Can you show a comparison using both 'adig' as well as bind's 'dig' utilities with an affected query? Those should both dump all records and show the behavior you mention,...
Thanks for that, it definitely confirms the behavior. The response flags also look wrong. What is curious though is the UDP payload size shown there, 208 bytes is a really...
The 'do' flag is for DNSSEC, which doesn't have anything to do with TLSA. Typically it is your upstream recursive DNS server that is doing DNSSEC, not the stub resolver...
In theory if the do flag is sent and the upstream validated, you'll get the ad flag back in the response ... assuming of course you trust your upstream recursive...
Is this actually emitting some warning somewhere ? This is valid in C to use an enum as a flags value, however C++ doesn't allow this. Are you trying to...