Brad Fitzpatrick

Results 299 comments of Brad Fitzpatrick

Okay, https://godoc.org/golang.org/x/sys/windows is now a Windows-only package and it renders nicely. (As "nicely" as an auto-generated syscall package can look, at least.)

It's intentional that it has a private method, so we can make assumptions safely in the code about the set of possible concrete type conversions. Rather than supporting custom sinks,...

Not really a fan of its name, nor expanding the API. I kinda consider this package done, working, and frozen. Can't your fill function do its own caching if that's...

@fbettag, we support Pull Requests on GitHub now. Still interested in finishing this?

I'm not seeing any changes. Did you forget to push?

There is no chat group for this project, and it's largely frozen. People use this and it works, but nobody is particularly interested in adding features (which has a cost...

Rather than add new config knobs, I'd rather just fix the implementation to pipeline request/responses onto the existing connections, rather than make so many.

Please squash the commits together. We don't want incremental work fixing code review comments in the history.

@Jleagle, where is it merged? I'm not seeing it.

GitHub just pinged me about this. Do you still need a review here? Sitting since September 9th makes me think this wasn't needed?