crypto
crypto copied to clipboard
golang
ssh: add hmac-sha2-512.
Hi! Thanks for the PR!
Unfortunately, the Go project doesn't use GitHub's Pull Requests, so we can't accept your contribution this way. We instead use a code review system called Gerrit.
The good news is, I'm here to help.
From here, you have two options:
- Read our Contribution Guidelines to learn how to send a change with Gerrit.
- Or, create an issue about the issue this PR addresses, so that someone else can fix it.
I'm going to close this Pull Request now. Please don't be offended! :-)
Thanks again,
GopherBot (on behalf of the Go Team)
@fbettag, we support Pull Requests on GitHub now. Still interested in finishing this?
Wohee, sorry was on a trip out of country. Would be great if you could pull it in :)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
- If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
- In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
Hey @fbettag we just need you to sign the CLA and we can start review. Thanks!
This PR (HEAD: 2f7b6a24772f2f6411c7d8d8c48dd78d4ee0c546) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/#/c/crypto/+/98056 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Brad Fitzpatrick:
Patch Set 1:
This doesn't apply cleanly against tip. Could you rebase?
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 712b88d7bc608e2b7fbebb968263cc1d00f9767b) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/#/c/crypto/+/98056 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Han-Wen Nienhuys:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Gerrit Bot:
Uploaded patch set 3: Commit message was updated.
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Brad Fitzpatrick:
Patch Set 3:
Was this for a particular client/server that required this?
What was the motivation?
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Franz Bettag:
Patch Set 3:
Sent from my iPhone
On 4. May 2018, at 21:57, Brad Fitzpatrick (Gerrit) <> wrote:
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
please ssh~ Add dialing timeout~ When the tcp connection is successful, the first packet is sent. If no response is received, the program will continue to stop responding.
Message from Gerrit User 28325:
Patch Set 3:
(1 comment)
I like the addition, one comment on the order.
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Nathan Hu:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Eric Brown:
Patch Set 4:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Eric Brown:
Patch Set 4: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
probably in 5-10 years it will be merged, meanwhile doing exec.Command("ssh".. 😆
Message from Gerrit User 5976:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Gerrit User 5065:
Patch Set 1:
This doesn't apply cleanly against tip. Could you rebase?
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Gerrit User 5893:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Gerrit User 5065:
Patch Set 3:
Was this for a particular client/server that required this?
What was the motivation?
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Gerrit User 26862:
Patch Set 3:
Sent from my iPhone
On 4. May 2018, at 21:57, Brad Fitzpatrick (Gerrit) <> wrote:
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Gerrit User 28325:
Patch Set 3:
(1 comment)
I like the addition, one comment on the order.
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Nathan Hu:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Eric Brown:
Patch Set 4:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!
Message from Eric Brown:
Patch Set 4: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/98056. After addressing review feedback, remember to publish your drafts!