Brad Fitzpatrick

Results 299 comments of Brad Fitzpatrick

250 commits is too much to review. Also, development has moved elsewhere. This is no longer the home for the version on the Play store.

Can you send the benchmarks separately? Also, net.IP isn't aliased to []byte. A type alias is a different thing. You meant an "underlying type": https://golang.org/ref/spec#Types

Okay, fix seems straightforward: ignore lines where rootfs is in that first field. Want to send a PR or want me to?

@chillum, interesting, it appears that your version of sfdisk doesn't spit out a "label: dos" or "label: gpt" line. What version do you have? I have: ``` # sfdisk -v...

I just pushed a fix, but I didn't test it. But it shouldn't be worse than today. Could you verify it works now, or reopen this with details of how...

Can you tell me the high-level steps for how to reproduce your environment on Azure and how to resize a disk on Azure?

Thanks! (unrelated side note: Azure doesn't let you resize a disk live? That's what embiggen-disk was really designed for, even though embiggen-disk is useful the reboot way)

Okay, I have an Azure instance up and I can reproduce.

So what's happening is that embiggen-disk had assumed that the partition being resized must be the final one. What this CentOS-on-Azure instance reports is: ``` # sfdisk -d /dev/sda #...