gomemcache icon indicating copy to clipboard operation
gomemcache copied to clipboard

Supports version and stats command.

Open bluele opened this issue 9 years ago • 12 comments

Hi. I hope this module supports version and stats command.

bluele avatar Jul 13 '14 14:07 bluele

Thanks for your reviews. i have fixed the above issues by commit 095fef0.

bluele avatar Jul 15 '14 17:07 bluele

Please squash the commits together. We don't want incremental work fixing code review comments in the history.

bradfitz avatar Jul 15 '14 17:07 bradfitz

I have fixed mutex-name and squashed the commits.

bluele avatar Jul 15 '14 18:07 bluele

@bradfitz 54b6dc1 Is this ok?

bluele avatar Jul 22 '14 14:07 bluele

@bradfitz Any plans to merge this soon? I was just looking for this exact stuff and almost started my own branch to add it.

eatstoomuchjam avatar Jan 07 '15 17:01 eatstoomuchjam

:arrow_up: :arrow_up: :arrow_up: :arrow_up:

hgfischer avatar May 27 '15 17:05 hgfischer

@bradfitz Ping :-) It'd be nice to get stats support merged.

SuperQ avatar Jul 05 '16 18:07 SuperQ

@bradfitz I second that from @SuperQ, I'd like to use Version as a health check.

tomdionysus avatar Jul 19 '16 03:07 tomdionysus

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Feb 08 '17 20:02 googlebot

I signed it!

bluele avatar Feb 08 '17 23:02 bluele

CLAs look good, thanks!

googlebot avatar Feb 08 '17 23:02 googlebot

@bradfitz @bluele I'd love to see support for Stats here soon. I was working on a similar PR when I found this one. Can I help push this over the finish line?

william-damon-hs avatar Nov 20 '18 20:11 william-damon-hs