gomemcache
gomemcache copied to clipboard
Supports version and stats command.
Hi.
I hope this module supports version
and stats
command.
Thanks for your reviews. i have fixed the above issues by commit 095fef0
.
Please squash the commits together. We don't want incremental work fixing code review comments in the history.
I have fixed mutex-name and squashed the commits.
@bradfitz 54b6dc1 Is this ok?
@bradfitz Any plans to merge this soon? I was just looking for this exact stuff and almost started my own branch to add it.
:arrow_up: :arrow_up: :arrow_up: :arrow_up:
@bradfitz Ping :-) It'd be nice to get stats support merged.
@bradfitz I second that from @SuperQ, I'd like to use Version as a health check.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If you signed the CLA as a corporation, please let us know the company's name.
I signed it!
CLAs look good, thanks!
@bradfitz @bluele I'd love to see support for Stats here soon. I was working on a similar PR when I found this one. Can I help push this over the finish line?