Brad Allred

Results 273 comments of Brad Allred

this work is [about to land](https://github.com/libsdl-org/SDL/pull/7067) in SDL 3. We should find some time to review the API in case #1771 needs to be nudged in a particular direction.

This is _possibly_ two problems. First is that the blend mode is incorrect; it should be something like `ONE_MINUS_DST`. In fact, if you look at 2be9403 you will see that...

ah, so all the other games use FLASH.BAM for the icon requiring `ONE_MINUS_DST`, where with BG2 it is FLASHBR.BAM. It does look like `ONE_MINUS_DST` is being applied everywhere then, which...

ok, it looks like the bug is here: https://github.com/gemrb/gemrb/blob/e16dad0787d4cfa48a1f7e5480d16e770cbaeb2b/gemrb/core/GUI/Button.cpp#L361-L368 we should also be checking that the animation is not complete, in addition to checking if the end frame `HasTransparency()`

hmmm, I'm not so sure since we should be clearing the animation when it ends: https://github.com/gemrb/gemrb/blob/e16dad0787d4cfa48a1f7e5480d16e770cbaeb2b/gemrb/core/GUI/Button.cpp#L114-L119 the problem then would be that the animation doesn't have `PLAY_ONCE` set. Can't really...

> * memorize another (plays fine, but the previous slot gets black until hovered over (one or the other slot, but nothing else fixes it)) thank you! this is the...

I've identified the cause, but I'm going to defer fixing it until after 0.9.2 as it is easy to introduce subtle regressions with drawing.

speaking of db transactions... isn't sqlite what the EEs use anyway? If we will have a need for sql to support those, it might make sense to just transition to...

yeah, I'm not sure what they use it for, I just know it is there :man_shrugging: If we have no need for it then we have no need for it....