class-validator icon indicating copy to clipboard operation
class-validator copied to clipboard

docs(IsDecimal): use correct docstring for IsDecimal

Open braaar opened this issue 3 years ago • 2 comments

Description

Use the correct docstring for the decorator IsDecimal. The existing one seems to have been copied from IsAlphanumeric: IsAlphanumeric source code

Checklist

  • [x] the pull request title describes what this PR does (not a vague title like Update index.md)
  • [x] the pull request targets the default branch of the repository (develop)
  • [x] the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • [x] tests are added for the changes I made (if any source code was modified)
  • [x] documentation added or updated
  • [ ] I have run the project locally and verified that there are no errors

Fixes

fixes #1423

braaar avatar Jan 20 '22 13:01 braaar

I think the merge commit made the Semantic Pull Request check fail?

braaar avatar Jan 20 '22 14:01 braaar

As long as we are using squash and merge I don't see any issue with the PR.

braaar avatar Jan 31 '22 09:01 braaar

Landed in https://github.com/typestack/class-validator/commit/42b9ca263cf855d2004c0dce23e38d23546148ac

NoNameProvided avatar Nov 13 '22 13:11 NoNameProvided

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Dec 14 '22 00:12 github-actions[bot]