Ben Plommer

Results 144 comments of Ben Plommer

I’ll need to look in more detail to give a specific answer to that - I’ll try to get to it soon.

> Hey @bplommer, but the idea is to still imlement `io.confluent.kafka.schemaregistry.client.SchemaRegistryClient` inteface right ? That would be a good step in the right direction, yes. Ideally I think I'd prefer...

> One more question, because I think I am missing something here :) We want to actually implement our own deserialization of Avro here? Since `KafkaAvroDeserializer/Serializer` are part of confluent...

Hi @keirlawson sorry for never replying to this! I think just having Avro support would be enough to be worth merging, though supporting json and protobuf too would also be...

Hi @gordon-rennie - so sorry for dropping the ball on this! I'll do my best to look at this properly over the weekend.

This looks great! I think I'm happy with the approach - any thoughts on this @vlovgr?

I think the main thing that makes `KafkaConsumerActor` confusing is that it doesn't encapsulate its internals - the queues etc are instantiated in `KafkaConsumer.scala` and exposed there. If they were...

@LMnet @vlovgr I'm thinking of cutting a release candidate in the next few weeks, and we can continue towards a 4.x release for further breaking changes - is there anything...

I might re-introduce support for Scala 2.12 in v3.x, to remove a reason for people to stay on v2.x - then we can drop it again for v4.x - what...

@vlovgr @LMnet what do you think? #902 hasn't been released in a non-milestone yet, so if we're going to go this way I'd like to revert it before releasing 2.5.0...