Ben Plommer

Results 144 comments of Ben Plommer

Having played with this a bit, I think the stream should instead emit an ADT with subtypes `Assigned(newlyAssignedPartitions: Map[TopicPartition, Stream[F, CommittableConsumerRecord[F, K, V]])` and `Revoked(revokedPartitions: SortedSet[TopicPartition])`. That's what the information...

Thanks for this contribution! I like this but I'm not sure about the name - maybe `labelledPartitionedStream`? Also, we can't add new abstract methods to `KafkaConsume` for binary compatibility reasons,...

That sounds good - the only thing I wonder is how we would handle prioritising client requests over polls? I wonder if instead of switching to `cats.effect.Semaphore` we should instead/first...

I'm thinking something like https://github.com/fd4s/fs2-kafka/pull/906 - does that fit with what you had in mind?

Based on quick experimentation, it looks like the following snippet is all you need - it doesn't even need anything Weaver-specific, just a resource of a running container: ```scala package...

That would be great for the AvroName feature (I've opened a ticket at #443). The relevant bit of code (for Scala 2) is at https://github.com/fd4s/vulcan/blob/26aaa0425821156c5b17b4d13491f630ffe50caa/modules/generic/src/main/scala-2/vulcan/generic/package.scala#L88-L92 - you should be able...

Re field mappers, the general philosophy in Vulcan is to encourage writing codecs manually and keep generic derivation as lightweight as possible, but I'm open to being persuaded 🙂

I'd like to keep the existing behaviour for defaults as it is, but we could add an `@AvroDefault` annotation to opt in to using the default field value from the...