Ben Plommer

> * `F.pure(serializer.serialize(topic, value))` doesn't seem quite right to me - `serializer.serialize` calls into the Java code, which is not pure and performs IO including checking a schema cache and...

Thanks for this, and sorry for the lack of response - a PR would be very welcome!

Sorry, I only just saw this - had my github notifications set up wrong  🤦‍♂️ I'll try give this some thought in the next few days.

I feel like removing commit recovery as a default behaviour would be a regression in terms of robustness and approachability, so I'd like to avoid that if possible. What if...

Ok, your first suggestion sounds reasonable to me. What do you think @vlovgr?

> I suggest removing `CommitRecovery` from the actor logic and move it to the `commit` method. Like this: > > ```scala > def commit(recovery: CommitRecovery = CommitRecovery.Default): F[Unit] > ```...

> Not sure about naming. SerializingKafkaProducer is a bit long. But I don't have a better alternative atm. Agreed. What about leaving `KafkaProducer` as it is and renaming `KafkaProducerConnection` to...

> After the first reading, I thought you are talking about typeclass to derive a key from the value. Simple function sounds better in this context because it's explicit and...

How about we rename `KafkaProducerConnection` to `GenericKafkaProducer` for 2.0, with a deprecated type alias as `KafkaProducerConnection`? Then the change should be mostly source-compatible, and it doesn't matter that it's binary...

I was also wondering about that - I was thinking about changing it in 3.0. Any thoughts on this @vlovgr ?