Ben Plommer
Ben Plommer
This looks good but I want to look more closely before approving it. Re mentioning multiple versions - if/when we migrate the docs to `sbt-typelevel-site` we can split that out...
Can't what you need to do be done in user code without being coupled to serialization? E.g. ```scala def headersFor(topic: String, a: A): F[Headers] = ??? def makeProducerRecord(topic: String, k:...
Or are you talking about wanting to be able to interop with an existing Java serializer that mutates Headers? If so I can see the case for that, though I...
Hi @felipehaack, thanks for the offer of help and sorry for the slow reply! I’ll try to give it some thought and get back to you soon. Assuming this is...
If the problem is just that the output of `Headers#toJava` is immutable, I think the following should work - it converts the headers to the Java class using a constructor...
Happened again in https://github.com/fd4s/fs2-kafka/runs/1762306979
And https://github.com/fd4s/fs2-kafka/pull/503/checks?check_run_id=1771040828
I guess to ensure the name is unique when there are multiple consumers? @vlovgr would know. But I think we could replace that with a global `AtomicLong` counter - a...
I tried aliasing the packages and it didn't work very well - instead I suggest we move the files without aliasing in 1.x, and then rename them for 2.x but...
Thanks for taking the time to do this! We haven't really focused much on performance so far but I think it's something we should look to do in the future....