Peter Pettersson
Peter Pettersson
Some thoughts that aren't specific to this PR but has to do with `C_STANDARD` in general: 1. I don't think the `C_STANDARD` set on the target is used for the...
The ftruncate test have been moved to util_tests. May be fixed by #6356
Duplicate of #5733
This could be a nice function to have, but it seems a bit specialized. This is more a personal choice but I think it feels a bit more natural to...
Since the preprocessor only does string replacement it would be possible to pass the expected variable name for git_str as an argument: ```c #define GIT_BUF_WRAP_PRIVATE(buf, fn, str) { \ git_str...
I don't think libgit2 even supports fsmonitor, at least I couldn't find any references to it.
It is possible that libgit2 may never run hooks by itself. There is some discussions about it in [#964 ](https://github.com/libgit2/libgit2/issues/964) In particular there are concerns about portability and error handling...
There is a bunch of `warning: array subscript has type ‘char’` from the character classification calls. That may cause any character with a value over 127 to be misclassified. We...
Could you compile with #6679 and see if any of the tests passes?
OK, I missed one isprint() in the pr, but I don't see that it would be cause any of the remaining failures. I don't really know why we are testing...