Peter Pettersson
Peter Pettersson
Could you post the output from "cmake .." In the automated test the MacOS build says: ``` ... -- Looking for iconv_open -- Looking for iconv_open - not found --...
OK, first a small disclaimer: I'm not a Mac user and mainly develop for microcontrollers and older systems so I will probably not be able to help you find the...
Could you also check what version of CMake you use?
It could be that the compiler uses include files that aren't compatible with the library you are linking against. There is some more info about it in this thread: [libiconv-or-iconv-undefined-symbol-on-mac-osx](https://stackoverflow.com/questions/57734434/libiconv-or-iconv-undefined-symbol-on-mac-osx)
Some of the errors are the same as #6655 but there seems to be some differences. One problem could be that we pass signed characters into the character classification macros....
Seems to be partly a duplicate of #6569
> I don't really remember the rationale for having some of the `git__` functions, but ... we do, and maybe we should continue to? > > Should we `#define git__isalnum(x)...
> Should we just get rid of the `git__` things entirely? I'm very torn on this. I suspect that we have a bunch of cases where these functions are used...
OK, so, if we take a commit made with a system with i18n.commitEncoding set to n_US.utf8 and process it on a system with i18n.commitEncoding set to en_US.iso885915 we will treat...
Unless you need this before Christmas I would prefer if you waited a bit. I have given it some more thought and think that we should probably keep rolling our...