Peter Pettersson

Results 24 comments of Peter Pettersson

I suspect the problem here is that the libgit2 cmake files sets the `C_STANDARD` to `C90` while using `C99` features. I think the reason for C90 is to get some...

The initial [commit](https://github.com/libgit2/libgit2/commit/3a3ab065f0685202c854e13708ddfd2a93d75e2c) for it might give a pretty good answer in the commit message. The corresponding PR #6133 have some more thoughts about it. > The goal is for...

Yep, `alloca` is non-posix. `const cli_opt_spec *given_specs[args_len + 1];` would probably be a better option in this case. Pretty much any argument that can be made against using VLA will...

Oh, my bad, I honestly thought MSVC had full C99 support but it seems like they never made any such claim. It does however seem like [they have deprecated `alloca`](https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/alloca?view=msvc-170)...