Bogdan Drutu
Bogdan Drutu
@mx-psi I am not sure if this is the right approach, here are some use-cases that would be good the new design (if any) should cover: * If collector is...
I think this is against the semantic conventions. To understand what I mean, see https://github.com/open-telemetry/opentelemetry-python/pull/3675 in otel we have standard semantic conventions for things like `lineno` and we should follow...
> @bogdandrutu Yeah it is. Scanning over SpanAttributes, there probably are a bunch more like thread.id. Is it ok if I just create an issue for it, something like "convert...
Few that I have in mind: * https://github.com/open-telemetry/semantic-conventions/blob/main/docs/exceptions/exceptions-logs.md * https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/attributes.md#source-code-attributes * https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/attributes.md#general-thread-attributes
Let's start that issue. We definitely need it. I think the best we can do is to have it as a subcommand but this is just me prematurely commenting 👯
> should BuildInfo be in this package? since its more directly tied to the service running, it might make more sense to move it to that package I think cannot...
> Before considering component 1.0, we need to review the public API to ensure what is exposed makes sense https://pkg.go.dev/go.opentelemetry.io/collector/component @codeboten we also need to make sure that "consumer" package...
My vote is to NOT do this, and to if needed use relevant names for the meter that produces these metrics.
I completely disagree with the name prefix for the same reason we don't want a "cpu.usage" metric to be named "otecol.cpu.usage" and "otelsdk.cpu.usage" those are wrong names in my opinion...
Not sure if this is a real problem, because this seem to work in CI, see https://github.com/open-telemetry/opentelemetry-collector/blob/main/.github/workflows/build-and-test.yml#L120 and https://github.com/open-telemetry/opentelemetry-collector/blob/main/Makefile#L81