Bogdan Drutu
Bogdan Drutu
Few things I would like to see here: * Interaction with https://github.com/open-telemetry/opentelemetry-collector/tree/main/client is strange. I would actually want to also clarify what we do with `client` package. I kind of...
Few others: * NetAddr -> AddrConfig? * NetTCP -> TCPConfig?
I think Scraper interface needs a bit more "love" than that. Will give a try to send some PRs/ideas soon
> go.opentelemetry.io/collector/service/process_telemetry here is probably just `otelcol`? > go.opentelemetry.io/collector/exporterhelper here we should calculate the scope name at runtime based on the exporter that uses the helper correct? > go.opentelemetry.io/collector/obsreport/processor same...
> I've liked when the scope name is actually a link to the godocs for the package (e.g. go.opentelemetry.io/collector/exporter/exporterhelper). It removes any ambiguity for someone trying to figure out where...
One unsure relationship is `extension` with `configs` since some configs wants the list of extensions to find a `storage` or an `auth` extension. Need to maybe dig dipper here.
Please fix contrib.
> Does otel agent support AWS MSK authentication via provider chain? Which component of the collector?
In general things that are high cardinality like generic "errors" are not best suited for metrics, and usually they should just be recorded like logs or span attributes.
> The suggestion is to use the GRPC status code, not the actual error text, i.e., https://github.com/grpc/grpc-go/blob/master/codes/codes.go#L37 Why not accept the code then?